search

jaegertracing / jaeger-analytics-java

Data analytics pipeline and models for tracing data
Apache License 2.0
45 stars 24 forks source link

Add readme for spinning up notebooks #53

Closed shreyagupta30 closed 3 months ago

shreyagupta30 commented 4 years ago

This fixes #51 I have added a readme file that provides instructions on how to spin up the jupyter notebooks for the Data Analytics.

cc: @jpkrohling

fktkrt commented 4 years ago

I've wanted to compose a similar guide to this one, but got buried in another projects. Anyway, please take a look at my PR https://github.com/jaegertracing/jaeger-analytics-java/pull/54 as it has a docker-compose solution, which can we used for this guide also, if you want to simply the process of setting these up.

If it makes sense, that can be merged, and this PR can be easily changed to use that compose. What do you think?

shreyagupta30 commented 4 years ago

@yurishkuro Thanks for your feedback. I will make the required changes

shreyagupta30 commented 3 years ago

Hi @jpkrohling and @yurishkuro, I have made the requested changes in the readme. Kindly review it and let me know if any further changes are required.

shreyagupta30 commented 3 years ago

Hi @jpkrohling, I have made the requested changes and it's ready for review. :)

jpkrohling commented 3 years ago

I'm unable to review it today, but will take a look soon.