search

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation
Apache License 2.0
249 stars 51 forks source link

feature: support write span via grpc stream #110

Closed vuuihc closed 2 years ago

vuuihc commented 2 years ago

Which problem is this PR solving?

Resolves #109

Short description of the changes

support write span via grpc stream

vuuihc commented 2 years ago

hi @pavolloffay @nickbp @EinKrebs If you have time, can you help to review this mr?

nickbp commented 2 years ago

The changes look good in principle to me, thanks for finding this optimization!

It looks like there are some compile-time errors relating to dependencies in CI, would you be able to take a look? Should be able to exercise the tests locally with e.g. make test/make e2e-tests/make integration-test (see also CI config )

vuuihc commented 2 years ago

@nickbp I fixed all the errors in tests, please review again, thanks.

nickbp commented 2 years ago

Great, looks like it's passing CI as well. Thanks!