search

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation
Apache License 2.0
247 stars 51 forks source link

Expose metrics #20

Closed chhetripradeep closed 3 years ago

chhetripradeep commented 3 years ago

Closes https://github.com/pavolloffay/jaeger-clickhouse/issues/19

Adds metrics for batch size and flush interval along with their count in prometheus exposition format.

Signed-off-by: Pradeep Chhetri pradeepchhetri4444@gmail.com

pavolloffay commented 3 years ago

@chhetripradeep could you please rebase?

chhetripradeep commented 3 years ago

Oops. Sorry my mistake. Doing it now.

chhetripradeep commented 3 years ago

@pavolloffay Thank you for the review. Sorry for delay on my side. It is ready for review again.

chhetripradeep commented 3 years ago

I think with rebase something break in metrics functionality. Fixing it.

chhetripradeep commented 3 years ago

Also rolled back the docker networking changes merged in earlier PR. It works as expected now. It is ready for review again.