Closed EinKrebs closed 3 years ago
Also:
@EinKrebs nit: generally try to keep changes in the PR minimal and rather split the PR into smaller PRs when doing multiple changes that do not belong together.
@EinKrebs PR needs to be rebased
@pavolloffay done.
It seems that there are some issue
This branch cannot be rebased due to conflicts
Rebasing the commits of this branch on top of the base branch cannot be performed automatically due to conflicts encountered while reapplying the individual commits from the head branch.
I am not sure what is the issue but I have also noticed that you are submitting the PR from your main branch. I would suggest using feature branches and keep main in sync with the upstream main branch.
Thank you for advice, it's really much easier to work like this.
I don't know why branch can't be rebased, when I try to rebase it my git does nothing
I made better version of this PR.
Can you please give me code review and some ideas about README content?
Resolves #18