Add writer unit tests - Githubissues

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation

Apache License 2.0

247 stars 51 forks source link

Add writer unit tests #32

Closed EinKrebs closed 3 years ago

EinKrebs commented 3 years ago

I can't figure out how to unit test span reader and writer, could you please give me some ideas?

pavolloffay commented 3 years ago

We might use https://github.com/DATA-DOG/go-sqlmock (or another similar library).

EinKrebs commented 3 years ago

Oh, thanks a lot, gonna look at this later.

pavolloffay commented 3 years ago

Also please add new make target and add CI job for tests.

EinKrebs commented 3 years ago

@pavolloffay I don't know, maybe it's better to merge this PR now, before I start to write test for SpanReader, 'cause its size is way too big already?