search

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation
Apache License 2.0
236 stars 50 forks source link

Make replicated deployment work without user explicitly creating tables #39

Closed pavolloffay closed 2 years ago

pavolloffay commented 3 years ago

The https://github.com/pavolloffay/jaeger-clickhouse/blob/main/guide-sharding-and-replication.md#replication requires uses to run SQL scripts on one node (bc we use ON CLUSTER).

We could add a new config option replication: true that would indicate that replication is enabled. The plugin would then use

cc) @EinKrebs is this smth that interests you?

EinKrebs commented 3 years ago

@pavolloffay yes, I'm gonna do this

EinKrebs commented 3 years ago

@pavolloffay should I add options for global table names too? I think it will be consistent.

pavolloffay commented 3 years ago

should I add options for global table names too?

There is already config to define the table names. We could automatically remove the local suffix if replication is enabled.

EinKrebs commented 3 years ago

Custom database names may not end with _local. Maybe it's better to automatically add it than to remove.

pavolloffay commented 2 years ago

Custom database names may not end with _local. Maybe it's better to automatically add it than to remove.

Why not? As far as I understand CH they will be local, but replicated.

The current config exposes options to set table names that are used in reader and writer. I don't see why we need another set of options for table names.

pavolloffay commented 2 years ago

Done in #53