jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation
Apache License 2.0
236 stars 50 forks source link

Document that replication does not work on default databse #66

Closed pavolloffay closed 2 years ago

pavolloffay commented 2 years ago

Signed-off-by: Pavol Loffay p.loffay@gmail.com

pavolloffay commented 2 years ago

@EinKrebs could you please review?

Also can you please check wit CH team to verify that all default databases use the ordinary DB engine? At least this is the case when using CH k8s operator.

EinKrebs commented 2 years ago

https://clickhouse.tech/docs/en/engines/database-engines/ Here, it's said that Atomic engine is used by default.

I checked this in default clickhouse server docker image, and here it's Atomic too.

SHOW CREATE DATABASE default

┌─statement──────────────────────────────┐
│ CREATE DATABASE default
ENGINE = Atomic │
└────────────────────────────────────────┘
pavolloffay commented 2 years ago

What is the version of CH?

here is my output:

SHOW CREATE DATABASE default

Query id: 368d9324-4c89-4109-98fb-d7132ce0776c

Connecting to localhost:9000 as user default.
Connected to ClickHouse server version 21.7.6 revision 54449.

┌─statement────────────────────────────────┐
│ CREATE DATABASE default
ENGINE = Ordinary │
└──────────────────────────────────────────┘

1 rows in set. Elapsed: 0.003 sec. 
pavolloffay commented 2 years ago

So the plain docker image uses Atomic engine but the operator sets the default DB to ordinary https://github.com/Altinity/clickhouse-operator/blob/0926d00a22be23499d633ce455bc5473a9620d15/deploy/operator/clickhouse-operator-install-template.yaml#L2335. I will document this.