search

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation
Apache License 2.0
236 stars 50 forks source link

Add Operation.SpanKind support #76

Closed EinKrebs closed 2 years ago

EinKrebs commented 2 years ago

Requirement - what kind of business use case are you trying to solve?

I ran jaeger grpc-plugin integration tests with this plugin and it failed.

Problem - what in Jaeger blocks you from solving the requirement?

Integration test failed because this plugin doesn't support jaeger/spanstore.Operation.SpanKind.

EinKrebs commented 2 years ago

I think it's needed to store tag keys separate from values in index table. @pavolloffay is this okay?

pavolloffay commented 2 years ago

Integration test failed because this plugin doesn't support jaeger/spanstore.Operation.SpanKind.

What do you exactly mean by this? The storage plugin wasn't able to query data based on the span kind? It's an implementation detail how the span kind will be queried.

EinKrebs commented 2 years ago

What do you exactly mean by this?

Jaeger wrote spans with span.kind tag, but GetOperations retrieved operations with empty SpanKind field.

EinKrebs commented 2 years ago

It's not necessary to implement this by now, but I guess it's better to do this anyway.