Added batch size regulation

jaegertracing / jaeger-clickhouse

Jaeger ClickHouse storage plugin implementation

Apache License 2.0

236 stars 50 forks source link

Added batch size regulation #79

Closed EinKrebs closed 2 years ago

EinKrebs commented 2 years ago

Which problem is this PR solving?

Some points in #75.

Short description of the changes

Now batch size is regulated by additive increase/multiplicative decrease algorithm.

pavolloffay commented 2 years ago

Could you please add more comments what the patch does?

We should perhaps also document this in config so people know how that the batch size is variable

EinKrebs commented 2 years ago

@pavolloffay As far as I can see, writer.writeBatch is safe to use concurrently, 'cause only db and logger are shared between its two calls. Sql.Db is safe for concurrent use for sure. For go-hclog I couldn't find any info, but I suppose it's safe too.