jaegertracing / jaeger-client-csharp

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
304 stars 67 forks source link

Support for GrpcSender #139

Closed Falco20019 closed 4 years ago

Falco20019 commented 5 years ago

Requirement - what kind of business use case are you trying to solve?

The new model.proto was defined in https://github.com/jaegertracing/jaeger/issues/904 and is accepted on GRPC port 14250 by the collector.

Problem - what in Jaeger blocks you from solving the requirement?

Currently not implemented in the client library.

rstraszewski commented 5 years ago

Isn't this endpoint created for agent - collector communication, not client library - agent?

gRPC endpoint for Agent will be created later, in phase 3 - https://github.com/jaegertracing/jaeger/issues/773

Falco20019 commented 5 years ago

It‘s analogous to the HTTP endpoint of Thrift for that we also have the HttpSender in case the user does want to communicate directly with collector without agent.

I checked again, and jaeger-client-go also supports directly talking to jaeger-collector over HTTP.

With Thrift it made a difference if you were to talk to jaeger-agent or jaeger-collector since the endpoint was different, although it's having the same API. Looking at the protos, I assume we will have a AgentService with a similar API, maybe using streams. In this case, we might want to add a flag to define if we want to use GRPC in agent or collector mode. Since we only have that, I would propose to only offer the collector-mode right now as default.

I am using GRPC in my project and want to get rid of the Thrift dependency as soon as possible and have no problems talking to the collector directly in my use case, so I thought there may be others who are also looking forward to this.

rstraszewski commented 5 years ago

Ok, I understand