search

jaegertracing / jaeger-client-csharp

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
302 stars 67 forks source link

Added support for 128bit to B3 decoder #144

Closed Falco20019 closed 5 years ago

Falco20019 commented 5 years ago

Which problem is this PR solving?

Fixes #143

Short description of the changes

Currently, B3 TraceId extraction only supports fallback to 64 bit. Since other tracers by now also support 128 bit, the behavior was aligned with the regular TextMapCodec again.

The HexCodec class was removed since it's redundant now with the FromString implementations of SpanId and TraceId. B3TextMapCodec earlier returned null on problems. Due to using the ExceptionCatchingExtractorDecorator, it's better to throw an exception that gets logged and still gracefully returns null.

yurishkuro commented 5 years ago

don't know what github is smoking...

image image