Fix blocking code - Githubissues

jaegertracing / jaeger-client-csharp

🛑 This library is DEPRECATED!

https://jaegertracing.io/

Apache License 2.0

302 stars 67 forks source link

Fix blocking code #191

Closed BojanPantovic1989 closed 4 years ago

BojanPantovic1989 commented 4 years ago

Which problem is this PR solving?

-Fixes #189

Short description of the changes

replace blocking collection with BufferBlock to make everything async

BojanPantovic1989 commented 4 years ago

@Falco20019 I wasn't able to test using 0.4.1, but I applied changes to make everything async.

phxnsharp commented 4 years ago

Looks great to me! Looks like maybe something went wrong the continuous integration above but I had written test cases for the original fix. If those still pass, I'm happy.

Thanks!

Falco20019 commented 4 years ago

The CI failed because there were some deprecation warnings (treated as errors) from NuGET. I just fixed them. I will rerun the CI.

@BojanPantovic1989 Can you please fix the DCO? Click on the "Details" link to get instructions for it.

BojanPantovic1989 commented 4 years ago

Hi @Falco20019 it should be fixed now.

Falco20019 commented 4 years ago

I'm testing it a bit more right now. I found that current 0.4.1 has problems if something on the sender goes wrong. Since we use command.ExecuteAsync().Wait();, this will throw an AggregateException instead of SenderException. This PR should fix it since it's using async/await again.

EngRajabi commented 4 years ago

Do not publish the version ?? We have a problem with version 0.4.1

Falco20019 commented 4 years ago

@EngRajabi Sorry, I missed that this is still open. I will release it now.

EngRajabi commented 4 years ago

@Falco20019 thanks