Jaeger server loses the refrence data of spans received from csharp client when using grpc sender.

jaegertracing / jaeger-client-csharp

🛑 This library is DEPRECATED!

https://jaegertracing.io/

Apache License 2.0

304 stars 67 forks source link

Jaeger server loses the refrence data of spans received from csharp client when using grpc sender. #202

Closed eventhorizon-cli closed 3 years ago

eventhorizon-cli commented 3 years ago

Jaeger Version 1.17 nuget packages used in client:

Jaeger" Version="0.4.2"
Jaeger.Senders.Grpc Version="0.4.2"

When I open the Trace Graph page in jaeger ui, it shows nothing due to all the refrence field of spans are all emty.

After comparing the logic of JaegerGrpcSpanConverter and JaegerThriftSpanConverter. I found the parentId of span is not sent to server in grpc sender. And parentId is used for building the refrence data in query api.

Falco20019 commented 3 years ago

You mostly got it right. The gRPC span is missing the parentSpanId that Thrift has. Therefore, we must add all references and must not skip the parent. Thanks for noticing!

Falco20019 commented 3 years ago

I just release 0.4.3. You should be fine to just reference Jaeger.Senders.Grpc without additionally Jaeger. If you address Jaeger, you will also add the Thrift stuff which you don't need.