search

jaegertracing / jaeger-client-go

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.39k stars 288 forks source link

FOSSA check is not actually running #551

Closed yurishkuro closed 2 years ago

yurishkuro commented 3 years ago

Sample build:

fossas/fossa-cli info checking GitHub for latest tag
fossas/fossa-cli info found version: 1.1.1 for v1.1.1/linux/amd64
fossas/fossa-cli info installed /usr/local/bin/fossa
INFO Initializing...
WARNING Filtering out suspicious module: _/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock/thrift/tracetest (_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock/thrift/tracetest)
WARNING Filtering out suspicious module: _/home/runner/work/jaeger-client-go/jaeger-client-go/testutils (_/home/runner/work/jaeger-client-go/jaeger-client-go/testutils)
INFO Analyzing module (1/1): _/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock
WARNING Could not determine whether module is built: ERROR: exit status 1
TROUBLESHOOTING: Fossa could not run command [go list -json
_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock] in directory
crossdock. Ensure that Go is installed and try running this command on your
own.
stderr: cannot find package
"_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock" in any of:
    /opt/hostedtoolcache/go/1.15.5/x64/src/_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock
(from $GOROOT)
    /home/runner/go/src/_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock
(from $GOPATH)
LINK: https://github.com/fossas/fossa-cli/blob/master/docs/integrations/golang.md#analysis

WARNING Module does not appear to be built
WARNING Error reading dependencies from `crossdock`: ERROR: exit status 1
TROUBLESHOOTING: Fossa could not run command [go list -json
_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock] in directory
crossdock. Ensure that Go is installed and try running this command on your
own.
stderr: cannot find package
"_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock" in any of:
    /opt/hostedtoolcache/go/1.15.5/x64/src/_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock
(from $GOROOT)
    /home/runner/go/src/_/home/runner/work/jaeger-client-go/jaeger-client-go/crossdock
(from $GOPATH)
LINK: https://github.com/fossas/fossa-cli/blob/master/docs/integrations/golang.md#analysis

INFO Uploading analysis...

============================================================

    View FOSSA Report:
    https://app.fossa.com/projects/custom+162%2Fgithub.com%2Fjaegertracing%2Fjaeger-client-go/refs/branch/HEAD/8f4f1b0beb2d2154104fdd17d92c2a0ab5a2cf3d

Most likely this is due to this repo not using go modules, so in order to build it we need some special setup as in https://github.com/jaegertracing/jaeger-client-go/blob/1b586b71ff1a76b4390b6b0c6f3f9552e33d927b/.github/workflows/unit-tests.yml#L24

@idvoretskyi can you confirm that FOSSA needs to run in the repository where normal go build commands work? Without go modules, it means being in the right path under GOPATH and having initialized vendor/ dir.

yurishkuro commented 3 years ago

Also, it's still puzzles me why the CLI doesn't exit with an error code when it fails. We can control whether the check itself is required or not via repo setting, but in the current state it just fails silently and looks like everything is green.

yurishkuro commented 3 years ago

I fixed the GOPATH issue in #552, but the FOSSA action still fails https://github.com/jaegertracing/jaeger-client-go/pull/553/checks?check_run_id=1465159886

It does not seem to understand pre-go-modules local vendor, even with GO111MODULE=off (#553).