search

jaegertracing / jaeger-client-go

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.38k stars 287 forks source link

Add support for go modules #583

Closed Nerzal closed 3 years ago

Nerzal commented 3 years ago

Add go.mod file to support go modules.

Which problem is this PR solving?

Short description of the changes

Yes, this can be done without upgrading jaeger-lib to go.mod. That change can be made later

Nerzal commented 3 years ago

I got all import paths, some more tweaks to build pipelines etc might still be needed. For that reason it would be good to see the pipeline results :D

yurishkuro commented 3 years ago

Did you run make test locally? The CI failed across the board. Since it requires manual approval for each run (for new contributors), it's much easy to verify everything locally first, by running make test lint crossdock.

Nerzal commented 3 years ago

I'll have an eye on it

Nerzal commented 3 years ago

The good news is:

grafik

Locally the tests do run.

Should the makefile be updated to use go modules instead of dep and all the other dependency management stuff? Or is using go modules considered optional and it must work with everything?

yurishkuro commented 3 years ago

yes, we would need to change makefile / CI to use modules and drop dep/glide

Nerzal commented 3 years ago

I'll check this out. Gonna take a day or two :)

Alex-duzhichao commented 3 years ago

Any progress here? Support go modules will make developers' life easier. Thanks :)

jpkrohling commented 3 years ago

@Alex-duzhichao, would you like to give it a try?

Nerzal commented 3 years ago

No real progress - reason is I simply had no time.