search

jaegertracing / jaeger-client-go

πŸ›‘ This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.38k stars 287 forks source link

Tweak thrift compilation #589

Closed aaronjheng closed 3 years ago

aaronjheng commented 3 years ago

Which problem is this PR solving?

Short description of the changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #589 (cfbaf3a) into master (b29e5f0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head cfbaf3a differs from pull request most recent head 75b4e56. Consider uploading reports for the commit 75b4e56 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   88.58%   88.58%           
=======================================
  Files          61       61           
  Lines        3328     3328           
=======================================
  Hits         2948     2948           
  Misses        252      252           
  Partials      128      128

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b29e5f0...75b4e56. Read the comment docs.

aaronjheng commented 3 years ago

I didn't realize there is such a difference between GNU sed and BSD sed. How about putting the recipe of thrift-compile in a script file and run it inside a container instance of jaegertracing/thrift?

aaronjheng commented 3 years ago

I create a draft PR #590.

yurishkuro commented 3 years ago

I like the other PR better

aaronjheng commented 3 years ago

Closing in favor of #590.