search

jaegertracing / jaeger-client-go

πŸ›‘ This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.38k stars 287 forks source link

Move thrift compilation to a script #590

Closed aaronjheng closed 3 years ago

aaronjheng commented 3 years ago

Signed-off-by: Aaron Jheng wentworth@outlook.com

Which problem is this PR solving?

Short description of the changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #590 (d84bece) into master (b29e5f0) will increase coverage by 0.06%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   88.58%   88.64%   +0.06%     
==========================================
  Files          61       61              
  Lines        3328     3328              
==========================================
+ Hits         2948     2950       +2     
+ Misses        252      251       -1     
+ Partials      128      127       -1
Impacted Files Coverage Ξ”
utils/reconnecting_udp_conn.go 91.54% <0.00%> (+2.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b29e5f0...d84bece. Read the comment docs.

yurishkuro commented 3 years ago

Local test:

$ \rm -rf thrift-gen/*
zsh: sure you want to delete all the files in /Users/ysh/golang/src/github.com/uber/jaeger-client-go/thrift-gen [yn]? y

$ git status
On branch thrift-gen
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    deleted:    thrift-gen/agent/GoUnusedProtection__.go
    deleted:    thrift-gen/agent/agent-consts.go
    deleted:    thrift-gen/agent/agent.go
    deleted:    thrift-gen/baggage/GoUnusedProtection__.go
    deleted:    thrift-gen/baggage/baggage-consts.go
    deleted:    thrift-gen/baggage/baggage.go
    deleted:    thrift-gen/jaeger/GoUnusedProtection__.go
    deleted:    thrift-gen/jaeger/jaeger-consts.go
    deleted:    thrift-gen/jaeger/jaeger.go
    deleted:    thrift-gen/sampling/GoUnusedProtection__.go
    deleted:    thrift-gen/sampling/sampling-consts.go
    deleted:    thrift-gen/sampling/sampling.go
    deleted:    thrift-gen/zipkincore/GoUnusedProtection__.go
    deleted:    thrift-gen/zipkincore/zipkincore-consts.go
    deleted:    thrift-gen/zipkincore/zipkincore.go

no changes added to commit (use "git add" and/or "git commit -a")

$ make thrift-compile
docker run -v "/Users/ysh/golang/src/github.com/uber/jaeger-client-go:/data" -u 501:20 jaegertracing/thrift:0.14 thrift -version
Thrift version 0.14.1
docker run -v "/Users/ysh/golang/src/github.com/uber/jaeger-client-go:/data" -u 501:20 jaegertracing/thrift:0.14 /data/scripts/gen-thrift.sh
[WARNING:/data/idl/thrift/jaeger.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/zipkincore.thrift:20] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/agent.thrift:22] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/sampling.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/jaeger.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/zipkincore.thrift:20] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/baggage.thrift:19] No generator named 'netcore' could be found!
[WARNING:/data/idl/thrift/crossdock/tracetest.thrift:20] No generator named 'netcore' could be found!

$ git status
On branch thrift-gen
nothing to commit, working tree clean