jaegertracing / jaeger-client-go

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.39k stars 288 forks source link

consider add more verbosity to error for http span sender #596

Closed Dentrax closed 2 years ago

Dentrax commented 3 years ago

Requirement - what kind of business use case are you trying to solve?

It's a bit hard to distinguish why collector return non-200 errors, like as following:

prometheus-prometheus-operator-kube-p-prometheus-0 thanos-sidecar {"caller":"logger.go:22","level":"error","msg":"error reporting span \"/thanos.Store/Info\": error from collector: 404","ts":"2021-09-10T18:02:45.713894993Z"}

We could not figure it out which endpoint it tries to send for, with what method and maybe body?

It had better to error out: with this request: [POST] http://foo/bar:8080 i got 404 instead of i got 404.

Problem - what in Jaeger blocks you from solving the requirement?

This line throws the error from collector: %d errors.

This function actually.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Wdyt?