search

jaegertracing / jaeger-client-go

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.38k stars 287 forks source link

sampler logger is NullLogger #608

Open tttoad opened 2 years ago

tttoad commented 2 years ago

Sampler initialization without logger injection.

func (sc *SamplerConfig) NewSampler(
    serviceName string,
    metrics *jaeger.Metrics,
)

should be change to

func (sc *SamplerConfig) NewSampler(
    serviceName string,
    metrics *jaeger.Metrics,
    logger jaeger.Logger
)

like 

func (rc *ReporterConfig) NewReporter(
    serviceName string,
    metrics *jaeger.Metrics,
    logger jaeger.Logger,
) (jaeger.Reporter, error) {