jaegertracing / jaeger-client-go

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
1.38k stars 287 forks source link

[Bug]: mismatched parameters #615

Open sklaski opened 1 year ago

sklaski commented 1 year ago

What happened?

I upgrades to latest github.com/uber/jaeger-client-go v2.30.0.

# contrib.go.opencensus.io/exporter/jaeger
../../../go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:76:11: a.client.SeqId undefined (type *agent.AgentClient has no field or method SeqId)
../../../go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/agent.go:77:31: not enough arguments in call to a.client.EmitBatch
        have (*"github.com/uber/jaeger-client-go/thrift-gen/jaeger".Batch)
        want (context.Context, *"github.com/uber/jaeger-client-go/thrift-gen/jaeger".Batch)
../../../go/pkg/mod/contrib.go.opencensus.io/exporter/jaeger@v0.2.1/jaeger.go:361:22: not enough arguments in call to obj.Write
// EmitBatch implements EmitBatch() of Agent interface
func (a *agentClientUDP) EmitBatch(batch *jaeger.Batch) error {
    a.thriftBuffer.Reset()
    a.client.SeqId = 0 // we have no need for distinct SeqIds for our one-way UDP messages
    if err := a.client.EmitBatch(batch); err != nil {
        return err
    }
// Parameters:
//  - Batch
func (p *AgentClient) EmitBatch(ctx context.Context, batch *jaeger.Batch) (_err error) {

Steps to reproduce

get version 2.30.0 run tests

Expected behavior

tests are running as befor

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

none, still in local environment

SDK

github.com/uber/jaeger-client-go v2.30.0+incompatible // indirect

Pipeline

No response

Stogage backend

No response

Operating system

WSL2 linux

Deployment model

No response

Deployment configs

No response

nlundbo commented 7 months ago

I had this same problem. I solved it by removing go.mod and go.sum and followed up with go mod init && go mod tidy Might be helpful for someone :+1: