Closed lukeplausin closed 2 years ago
Merging #281 into master will decrease coverage by
0.07%
. The diff coverage is91.17%
.
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 95.03% 94.96% -0.08%
==========================================
Files 25 26 +1
Lines 1935 1967 +32
Branches 260 264 +4
==========================================
+ Hits 1839 1868 +29
- Misses 64 65 +1
- Partials 32 34 +2
Impacted Files | Coverage Δ | |
---|---|---|
jaeger_client/tracer.py | 99.35% <ø> (ø) |
|
jaeger_client/span.py | 95.31% <83.33%> (-1.27%) |
:arrow_down: |
jaeger_client/span_autologger.py | 95.23% <95.23%> (ø) |
|
jaeger_client/__init__.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2bb9d0c...1685ac9. Read the comment docs.
279
The goal of this pull request is to give developers an easy way of capturing logging output from their instrumented applications using the Jaeger client library.
This change will add a new optional parameter when creating Span objects - span_logger. This may be set to either a python logger object, or None. If set to a python logger object, messages sent to that logger will also be sent to the tracer under the current span, whilst the span is active. This is achieved using a custom logging handler to capture emit events. Once the span is closed, the the custom log handler is removed from the logging object and log entries are no longer sent to the tracer.
Added unit test Added a section in README.md
Signed-off-by: Luke Plausin luke.plausin@gmail.com