jaegertracing / jaeger-client-python

🛑 This library is DEPRECATED!
https://jaegertracing.io/
Apache License 2.0
408 stars 155 forks source link

Specify minimal required python version #314

Closed ethframe closed 3 years ago

ethframe commented 3 years ago

Which problem is this PR solving?

Short description of the changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #314 (80fc2f6) into master (a30a03e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          25       25           
  Lines        1967     1967           
  Branches      272      272           
=======================================
  Hits         1877     1877           
  Misses         56       56           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a30a03e...80fc2f6. Read the comment docs.

ethframe commented 3 years ago

current latest package (4.5.0) should be removed from PyPI

On second thought, removing package from PyPI is a bad idea, and it would be better to release a new fixed package with version 4.5.2, and then reupload 4.4.0 as 4.5.1.

condorcet commented 3 years ago

I think it would be better to release post-version of existing package according to PEP 440 https://www.python.org/dev/peps/pep-0440/#post-releases The changes are corresponding semantic of post-release, because it's actually not a bug fix So latest release will be 4.5.0.post1

yurishkuro commented 3 years ago

Why can't we just release a new version?

ethframe commented 3 years ago

Why can't we just release a new version?

Because pip on python 2.7 will still install the incompatible 4.5.0 if user doesn't pin specific version or there is no newer package that actually works on 2.7.