search

jaegertracing / jaeger-idl

A set of shared data model definitions used by Jaeger components.
http://jaegertracing.io/
Apache License 2.0
82 stars 74 forks source link

Type mismatch in RateLimitingSamplingStrategy #43

Open Falco20019 opened 6 years ago

Falco20019 commented 6 years ago

According to the sampling.thrift spec, the maxTracesPerSecond field should be an short value. The Java implementation uses a double value in it's ratelimiting_sampling.json and also in it's implementation.

I assume the thrift file is out of date and double is the correct type?

black-adder commented 6 years ago

Sorry for taking so long to respond to this. Ideally maxTracesPerSecond should be double. All the rate limiting samplers in the clients for every language can handle double maxTracesPerSecond. When we move over to using protobuf to define our idl, we can address this.