search

jaegertracing / jaeger-kubernetes

Support for deploying Jaeger into Kubernetes
https://jaegertracing.io/
Apache License 2.0
450 stars 158 forks source link

Use recommended labels #113

Closed naseemkullah closed 5 years ago

naseemkullah commented 5 years ago

Which problem is this PR solving?

Not a problem per se, but using standards helps everybody in the long run.

Short description of the changes

Using recommended labels as per https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

If approved I will go on to make a similar change to the incubating helm chart.

PS Also updated some images.

TIA

jpkrohling commented 5 years ago

We had a very similar PR for the Operator: https://github.com/jaegertracing/jaeger-operator/pull/172

It would be nice to be consistent here, especially regarding backwards compatibility.

naseemkullah commented 5 years ago

Thanks @jpkrohling , I've added back the original app label for backwards compatibility. Please let me know if this will suffice.

naseemkullah commented 5 years ago

Great, thanks @jpkrohling !

naseemkullah commented 5 years ago

bump

jpkrohling commented 5 years ago

Thanks for reminding me and thanks for your contribution!

naseemkullah commented 5 years ago

My pleasure!