search

jaegertracing / jaeger-kubernetes

Support for deploying Jaeger into Kubernetes
https://jaegertracing.io/
Apache License 2.0
450 stars 158 forks source link

fix(all-in-one): support for Kubernetes v1.16+ #132

Open subnetmarco opened 4 years ago

subnetmarco commented 4 years ago

The extensions/v1beta1 API version is deprecated and no longer supported in Kubernetes v1.16+ and fails with the following error:

unable to recognize no matches for kind "Deployment" in version "extensions/v1beta1"

This PR makes the jaeger-all-in-one-template.yml compatible with newer version of Kubernetes.

pavolloffay commented 4 years ago

@subnetmarco thanks for the PR.

To merge this we should probably bump the minikube version to pass the CI. Also the commits have to be signed (DCO).

objectiser commented 4 years ago

@subnetmarco could you also apply the same fix to the production template?

subnetmarco commented 4 years ago

@objectiser done with my last commit ca16ed255e5696a8b9d7d6556dcb02eb8901bbd9

objectiser commented 4 years ago

Hi @subnetmarco can you also address the points raised by Pavol in https://github.com/jaegertracing/jaeger-kubernetes/pull/132#issuecomment-608287318

pavolloffay commented 4 years ago

We are going to deprecate the repository. Please have a look at https://github.com/jaegertracing/jaeger-operator/#experimental-generate-kubernetes-manifest-file and share your feedback.