search

jaegertracing / jaeger-lib

A collection of shared infrastructure libraries used by different components of Jaeger.
https://github.com/uber/jaeger
Apache License 2.0
67 stars 35 forks source link

Add _total suffix for counters reported to prometheus #54

Closed objectiser closed 5 years ago

objectiser commented 5 years ago

Which problem is this PR solving?

As discussed in the prometheus documentation, "an accumulating count has total as a suffix".

Short description of the changes

If the counter does not have the _total suffix, then it will be added.

This change will also be required to bring the Go tracer inline with the metrics being reported by the Java tracer, which is using the micrometer library that applies a similar transformation on the counter metric names. See https://github.com/jaegertracing/jaeger-client-java/pull/564.

Signed-off-by: Gary Brown gary@brownuk.com

codecov[bot] commented 5 years ago

Codecov Report

Merging #54 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          26     26           
  Lines         719    723    +4     
=====================================
+ Hits          719    723    +4
Impacted Files Coverage Δ
metrics/prometheus/factory.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0a812e...ae98683. Read the comment docs.