jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Adding storage definition for elasticsearch with deployment configuration #104

Closed ofirattia closed 5 years ago

ofirattia commented 5 years ago

Which problem is this PR solving?

Short description of the changes

ofirattia commented 5 years ago

Travis is failing on license header checks and the header exists in both files.

jpkrohling commented 5 years ago

Could you please run mvn license:format, to get the headers fixed? The problem might be that we are in 2019 and the headers are for 2018.

ofirattia commented 5 years ago

@ofirattia thanks for the PR.

We do not want to support storage deployments in this repository and rather defer on well tested solutionns out there - e.g. elasticsearch from pires or helm charts.

The elasticsaarch template what is in this repository is only for "try it out" purpose. I am not even sure if the ES is configured with the right discovery (the same for your deployment)

thanks for your quick reply, actually I tested it with 120 instances on our cluster, I am not sure if it will be used in the same configuration for production, but for performance tests and user acceptance for sure. I found it useful.

Anyway, its seems that there is no recommended approach for production and its kind of do it your own.

do you want to add the storage configuration as example in the README or what you have now its enough from your side?

pavolloffay commented 5 years ago

do you want to add the storage configuration as example in the README or what you have now its enough from your side?

I think it's enough what we have. I believe similar examples can be found in k8s docs.

ofirattia commented 5 years ago

Thanks, Closed.

jpkrohling commented 5 years ago

@ofirattia in any case, thanks for your PR! I'd be really interested in hearing more about your tests:

actually I tested it with 120 instances on our cluster

Are you able to provide more info? Feel free to ping me via Gitter or IRC.