search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Replaced the underlying Cassandra image #24

Closed jpkrohling closed 7 years ago

jpkrohling commented 7 years ago

fixes #11 #19

jpkrohling commented 7 years ago
yurishkuro commented 7 years ago

@jpkrohling 278 is merged, but do you need a tagged release here?

jpkrohling commented 7 years ago

In theory, no, because each commit reaching master should push a new image to DockerHub and it becomes available as "latest": https://hub.docker.com/r/jaegertracing/jaeger-cassandra-schema/tags/

But as Travis is not running, it's not publishing new builds. So, I'd either need permissions to push to the jaegertracing, or will need someone to locally build the image and push it to DockerHub. Or, better yet, fix Travis, but as this might take longer.

pavolloffay commented 7 years ago

But will it be a proper tag? Like 0.5.0 we would like to use this tag in templates

jpkrohling commented 7 years ago

The tag in the template is another task. For this task, it's not needed, as the template defaults to latest. So, as long as the image is available under latest, this PR will work.

pavolloffay commented 7 years ago

Yes, but If I would use this with 0.5.x it wouldn't and that is the only working tag, so we should consider including it here or in a new tag (0.5.1)?

jpkrohling commented 7 years ago

I'm confused now :) @yurishkuro , were you asking if this repo needs a new tagged version, or were you asking if I need a new tagged version of the Docker image at DockerHub?

EDIT: I just noticed (thanks @pavolloffay!) there was a change in how the images are pushed to Docker Hub. Previously, every commit was a new image push to Docker Hub, so, latest would just work. This is not true anymore, so, yes, I would need a tagged version of Jaeger before this PR can be merged.

yurishkuro commented 7 years ago

I released 0.5.2, the images should be published shortly

jpkrohling commented 7 years ago

The version 0.5.2 is published, but the latest reference hasn't been updated. Would you please set latest tag to point to this version?

yurishkuro commented 7 years ago

We probably need to update the upload script, since latest has been replaced with the version tag. Perhaps we shouldn't be pushing latest at all? You can use 0.5, which will be "latest for 0.5.x"

jpkrohling commented 7 years ago

For this PR, I'll use 0.5, and we can later discuss how to move forward. For the record: I prefer a latest to exist.

jpkrohling commented 7 years ago

@pavolloffay I think this is now ready to be merged.

pavolloffay commented 7 years ago

LGTM, but I haven't run it (only k8s version). If you need manual tests I would prefer that our QE should be responsible for this.

objectiser commented 7 years ago

@jpkrohling There is no tag 0.5 for the all-in-one docker image :( Either need to revert the all-in-one template back to using latest or the docker image needs to be tagged.