search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Changed deployment verification command on jenkinsCI #26

Closed jkandasa closed 7 years ago

jkandasa commented 7 years ago

@objectiser JenkinsCI won't take the change from this PR. It will keep old jenkins-ci/Jenkinsfile. Here are the conditions on JenkinsCI configuration,

image

objectiser commented 7 years ago

@jkandasa So what do you suggest? Do we have to merge and hope it fixes the issue?

Is there a better solution - i.e. can the jenkinsfile just be configured in the jenkins job rather than having it as part of the git repo? If so - might be better solution as we may want the same pipeline triggered from multpile repos anyway.

jkandasa commented 7 years ago

@objectiser

Is there a better solution - i.e. can the jenkinsfile just be configured in the jenkins job rather than having it as part of the git repo? If so - might be better solution as we may want the same pipeline triggered from multpile repos anyway.

We can configure this file(Jenkinsfile) on Jenkins server itself. In this case, we have to maintain this file separately. When we have this file a part of the repository, If we lose our Jenkins server. We can setup another server with in a minute. And more features are here >> https://jenkins.io/doc/book/pipeline-as-code/

For this PR, I switched to Trust Everyone and triggered test. and switched back to Trust only From users with Admin or Write permission. So jenkins CI takes Jenkinsfile from PR and executed the job.

objectiser commented 7 years ago

@jkandasa Thanks!