search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Move collector route to a separate file + test it #55

Open pavolloffay opened 6 years ago

pavolloffay commented 6 years ago

Re-opening - let's improve this and move it to a separate resource file. @kevinearls should confirm how it will be tested

kevinearls commented 6 years ago

@pavolloffay I've confirmed this manually by taking the following steps

  1. Deploying Jaeger and ElasticSearch to minishift using the production templates
  2. Created a route to the collector using the "oc create route edge" command that you added to the readme.
  3. Ran the CreateTraces program from https://github.com/Hawkular-QE/jaeger-standalone-performance-tests
  4. Validated the trace count with "curl http://elasticsearch:9200/jaeger-span-2018-02-26/_count"

Everything worked correctly. Is this sufficient or do we need to add an automated test somewhere?

pavolloffay commented 6 years ago

Would that test work given that jenkins and tests are executed from inside the cluster?

kevinearls commented 6 years ago

At the moment all tests are executed from inside the cluster.

pavolloffay commented 6 years ago

@kevinearls could you confirm that a test could be implemented for this route given that tests are executed from inside the cluster?

kevinearls commented 6 years ago

@pavolloffay I've submitted https://github.com/jaegertracing/jaeger-openshift/pull/57 . This will create the route and test it using a job that runs in Jenkins inside the cluster. I've manually tested it from outside the cluster, but at the moment we don't have a non-OpenShift Jenkins we can use.

pavolloffay commented 6 years ago

Let's keep this open, until the route is defined in a separate file