search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Allow Jenkinsfile to be changed in PRs from forks #62

Closed pavolloffay closed 6 years ago

pavolloffay commented 6 years ago

See: https://github.com/jaegertracing/jaeger-openshift/pull/60#issuecomment-373039841

kevinearls commented 6 years ago

There is a way to do this in the Jenkins job configuration by changing Branch Configuration/Discover pull requests from forks/Trust to "Contributors" instead of the recommended "From Users with Admin or Writer Permission".

However, this does raise security issues, so I suggest we leave it as is for now. If necessary we can change it in the future.