search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

All-in-one template does not expose 5778 by default #73

Closed maximmold closed 6 years ago

maximmold commented 6 years ago

I have a Spring boot based application that creates the Tracer bean with Configuration.fromEnv().getTracer(). I set the appropriate environment variables to point to the sampler manager, but by default I was getting no entries in the jaeger ui. I finally figured out that sampling was not happening presumably because the agent port 5778 was not being exposed by default. Once I exposed it, everything worked fine. I would think this example template would have this exposed by default and the instructions I've seen for running locally with docker expose this port by default. It feels like there should be a warning at the very least if the sample manager cannot be contacted and sampling is therefore disabled.

maximmold commented 6 years ago

Here is the file of concern: https://github.com/jaegertracing/jaeger-openshift/blob/master/all-in-one/jaeger-all-in-one-template.yml

jpkrohling commented 6 years ago

@maximmold would you be interested in contributing with a fix?

maximmold commented 6 years ago

Here's a pull request. Please do a squash commit on this. https://github.com/jaegertracing/jaeger-openshift/pull/80