jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Fix for missing agent port #80

Closed maximmold closed 6 years ago

maximmold commented 6 years ago

Please do a squash commit when accepting this pull request since I had a few false starts.

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#1: Console log: external, internal

jpkrohling commented 6 years ago

Travis is failing, because the license plugin is expecting a header like this, as this is the first change of the year for this file :)

# Copyright 2017-2018 The Jaeger Authors

So, could you please run mvn license:format and update the PR? Or, if you prefer, just use the line above for all-in-one/jaeger-all-in-one-template.yml

jpkrohling commented 6 years ago

Just noticed that the commit is also missing the DCO. Could you please check the following link and sign-off your commits?

https://github.com/probot/dco#how-it-works

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#2: Console log: external, internal

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#3: Console log: external, internal

jpkrohling commented 6 years ago

@maximmold, I'm truly sorry, but your commit is still missing the "DCO". This is required in order for us to accept your contribution.

All it takes is to use the "sign-off" option in git, like:

git commit --signoff --amend

Please, do read the following to understand what DCO is and how it works: https://github.com/probot/dco#how-it-works

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#4: Console log: external, internal

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#5: Console log: external, internal

jpkrohling commented 6 years ago

Thank you, @maximmold !