search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Remove executable as an argument to containers #81

Closed zdicesare closed 6 years ago

zdicesare commented 6 years ago

Jaeger containers were changed to no longer require the path to the executable as an argument to docker run, so remove all instances of executable path

Signed-off-by: Zachary DiCesare zachary.v.dicesare@gmail.com

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#1: Console log: external, internal

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#2: Console log: external, internal

jpkrohling commented 6 years ago

I added the WIP marker to the title for the same reason as https://github.com/jaegertracing/jaeger-kubernetes/pull/87#issuecomment-389445294

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#3: Console log: external, internal

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#4: Console log: external, internal

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#1: Console log: external, internal

zdicesare commented 6 years ago

Build will fail until 1.6 images are out

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#1: Console log: external, internal

jkandasa commented 6 years ago

@zdicesare @jpkrohling

Collector service failed to start,

container_linux.go:247: starting container process caused "exec: \"--config-file=/conf/collector.yaml\": stat --config-file=/conf/collector.yaml: no such file or directory"

Query service failed to start,

container_linux.go:247: starting container process caused "exec: \"--config-file=/conf/query.yaml\": stat --config-file=/conf/query.yaml: no such file or directory"
zdicesare commented 6 years ago

Sorry about that @jkandasa, should be resolved now.

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#2: Console log: external, internal

jaegerci-bot commented 6 years ago

:red_circle: Jenkins CI Build#4: Console log: external, internal

jkandasa commented 6 years ago

@zdicesare np. Thank you! I see some test failures. I will check it and update here.

jaegerci-bot commented 6 years ago

:white_check_mark: Jenkins CI Build#4: Console log: external, internal

jkandasa commented 6 years ago

@jpkrohling @zdicesare Tested this on another OpenShift environment, all works well. from test side LGTM!