search

jaegertracing / jaeger-openshift

Support for deploying Jaeger into OpenShift
https://jaegertracing.io/
Apache License 2.0
57 stars 37 forks source link

Convert production cassandra config to a template with volumeClaimTemplate support #89

Closed gregswift closed 6 years ago

gregswift commented 6 years ago

Which problem is this PR solving?

Short description of the changes

The built in cassadnra template doesnt really work with persistent data. Changing it to a template, and introducing volumeClaimTemplate in the StatefulSet makes it so its usable for being able to scaling at all.

That being said apparently according to #30 it doesnt seem like there is a goal of making the cassandra* bits in this repo prod ready?

jpkrohling commented 6 years ago

That being said apparently according to #30 it doesnt seem like there is a goal of making the cassandra* bits in this repo prod ready?

That's correct: we provide the template as a starting point, but we have no intention in getting into the business of providing a production-grade Cassandra installation :-)

jpkrohling commented 6 years ago

Thanks for the PR! Looks good to me, except for a couple of places where it seems a } is missing.

rackergs commented 6 years ago

I thought i had caught all of those :/

updated.

my whole point in making this happen was to actually use this as the prod data store because it was already openshift prepared. So i'm a bit torn around what to move forward with :/

jpkrohling commented 6 years ago

my whole point in making this happen was to actually use this as the prod data store because it was already openshift prepared. So i'm a bit torn around what to move forward with :/

You probably know this better than me, but having Cassandra on Kubernetes/OpenShift is tricky, as pods come and go without notice. As far as I understand, this is not a pattern that Cassandra is particularly fond of. @pavolloffay and/or @burmanm can probably give you more details, as they spent more time on it than I have. Besides, at the time we wrote this OpenShift template, there hasn't been any official/supported way of running Cassandra on them, other than a few quick starts/tutorials here and there. This might have changed, though.

In any case, the main point is that we expect users to understand what they are doing with their Cassandra installation and be able to self-support: we can help with the Jaeger parts, but we can't help with the Cassandra parts.

jpkrohling commented 6 years ago

Sorry for taking so long to merge this!

gregswift commented 6 years ago

thanks