Agent as sidecar - wrong deployment snippet in readme

fgiloux commented 6 years ago

Hi

Requirement - what kind of business use case are you trying to solve?

This is just about an error in the doc: https://github.com/jaegertracing/jaeger-openshift

Problem - what in Jaeger blocks you from solving the requirement?

An error in the doc. The sidecar container does not start

Proposal - what do you suggest to solve the problem or improve the existing situation?

`command:

"--collector.host-port=jaeger-collector.jaeger-infra.svc:14267" should be replaced with (as in the Kubernetes readme): args:
- '--collector.host-port=jaeger-collector.jaeger-infra.svc:14267'`

Any open questions to address

I can create a pull request if that's of any help

Regards,

Frédéric

jpkrohling commented 6 years ago

Great catch, a recent change in the underlying image probably caused this. Would you mind sending a PR? IIRC, the jaeger-query service from the production template has an example of sidecar deployment (see #90)

fgiloux commented 5 years ago

PR created

jpkrohling commented 5 years ago

Closed by #94

jaegertracing / jaeger-openshift