jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.03k stars 345 forks source link

jaeger collector sampling not working with Ambassador #1078

Closed Space-Banana-42 closed 4 years ago

Space-Banana-42 commented 4 years ago

I am using jaeger 1.18, with sampling strategy:

kind: Jaeger
metadata:
  name: jaeger
spec:
  strategy: production
  sampling:
    options:
      default_strategy:
        type: probabilistic
        param: 0.1

  storage:
    type: elasticsearch
    options:
      es:
        server-urls: http://elasticsearch-master.openfaas:9200

And using zipkin tracer in ambassador:

apiVersion: v1
kind: Service
metadata:
  name: zipkin
  annotations:
    getambassador.io/config: |
      ---
      apiVersion: ambassador/v1
      kind: TracingService
      name: tracing
      service: zipkin:9411
      driver: zipkin
  labels:
    app: jaeger
    app.kubernetes.io/name: jaeger
    app.kubernetes.io/component: zipkin
spec:
  ports:
    - name: jaeger-collector-zipkin
      port: 9411
      protocol: TCP
      targetPort: 9411
  selector:
    app.kubernetes.io/instance: jaeger
    app.kubernetes.io/component: collector
  type: ClusterIP

But sampling strategy just doesn't work, jaeger still keeps all the traces. Any idea on how to fix that? Thanks a lot!

objectiser commented 4 years ago

@Space-Banana-42 The sampling configuration within the Jaeger operator's CR is only understood by the Jaeger tracers, not Zipkin tracers.