search

jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.02k stars 345 forks source link

Enabling external labels for Jaeger pods #1429

Open munipravy opened 3 years ago

munipravy commented 3 years ago

For enabling pod level labeling in Jaeger do we have spec recommended way ?

jpkrohling commented 3 years ago

The labels you specify as part of the Jaeger CR should be propagated down to the underlying resources, including pods.

munipravy commented 3 years ago

@jpkrohling I am using spec.metadata.labels to mention labels at pod level as mentioned below.

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-cluster
spec:
  metadata:
    labels:
      foo: bar
  strategy: production

But labels are not reflecting at Jaeger pod level.

When I am describing my Jaeger pod I can see values as mentioned below.

Labels:       control-plane=elastic-operator-jaeger
              controller-revision-hash=elastic-operator-jaeger-6bb95d7bb4
              statefulset.kubernetes.io/pod-name=elastic-operator-jaeger-0

Expectation 

Labels:       control-plane=elastic-operator-jaeger
              controller-revision-hash=elastic-operator-jaeger-6bb95d7bb4
              statefulset.kubernetes.io/pod-name=elastic-operator-jaeger-0
              foo: bar
jpkrohling commented 3 years ago

@rubenvp8510 , could you please take a look?

esnible commented 3 years ago

@munipravy should it be

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-cluster
spec:
  labels:
      foo: bar
  strategy: production

I don't think we have a spec.metadata.labels.

kubectl explain jaeger.spec.labels
...
FIELD:    labels <map[string]string>
...

kubectl explain jaeger.spec.metadata.labels

error: field "metadata" does not exist