search

jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.02k stars 344 forks source link

Remove tracing-enabled flag #1506

Open rubenvp8510 opened 3 years ago

rubenvp8510 commented 3 years ago

This issue is for tracking a discussion that started here: https://github.com/jaegertracing/jaeger-operator/pull/1484#discussion_r667997839

jpkrohling commented 3 years ago

We are using otel-sdk as the instrumentation library for the operator. As such, we can configure a logging exporter if the operator is in debug mode (log-level=debug). Additionally, we should configure the Jaeger/OTLP exporter if we can detect a destination. For instance, if a flag with the destination is specified, or if an instance exists in a specific location.

Perhaps the flag should be kept, in order to disable the behavior above. For instance, people might want debug-level logging but no tracing information in the logs or people might not want to see operator traces in their Jaeger instance. If we decide to keep the flag, we need to change the default value of this flag from false to true.