jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.03k stars 345 forks source link

fixes [Bug]: imagePullSecrets is not set for agent DaemonSet #2210 #2563

Closed antoniomerlin closed 6 months ago

antoniomerlin commented 6 months ago

Resolve #2210 Modify ImagePullSecrets input in agent.go definition to accept imagePullSecrets defined under agent for daemonset strategy. Verified the changes by running TestAgentImagePullSecrets test in agent_test.go and also modified the spec referencd for ImagePullSecrets test.

Checklist

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.71%. Comparing base (2482014) to head (97afe37).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2563 +/- ## ======================================= Coverage 87.71% 87.71% ======================================= Files 102 102 Lines 7308 7308 ======================================= Hits 6410 6410 Misses 701 701 Partials 197 197 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iblancasa commented 6 months ago

Thanks @antoniomerlin for your PR!