Open antoniomerlin opened 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.71%. Comparing base (
70e511a
) to head (f82e648
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for your contribution! Can you create a test?
Hi, @iblancasa test is already preset in pkg/autodetect/main_test.go and its working. Do i need to add anything else ?
I was thinking more about an E2E test or adding a new test. If after the change, none of the tests are modified it means we are not checking for the correct result.
By providing default ingressClass using detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test