jaegertracing / jaeger-operator

Jaeger Operator for Kubernetes simplifies deploying and running Jaeger on Kubernetes.
https://www.jaegertracing.io/docs/latest/operator/
Apache License 2.0
1.03k stars 345 forks source link

fixes #2225 #2622

Open antoniomerlin opened 4 months ago

antoniomerlin commented 4 months ago

By providing default ingressClass using detectDefaultIngressClass func updated API call to use client.Reader instead of client.Client

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.71%. Comparing base (70e511a) to head (f82e648).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2622 +/- ## ======================================= Coverage 87.71% 87.71% ======================================= Files 102 102 Lines 7308 7308 ======================================= Hits 6410 6410 Misses 701 701 Partials 197 197 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iblancasa commented 4 months ago

Thanks for your contribution! Can you create a test?

antoniomerlin commented 4 months ago

Hi, @iblancasa test is already preset in pkg/autodetect/main_test.go and its working. Do i need to add anything else ?

iblancasa commented 4 months ago

I was thinking more about an E2E test or adding a new test. If after the change, none of the tests are modified it means we are not checking for the correct result.