jaegertracing / jaeger-ui

Web UI for Jaeger
http://jaegertracing.io/
Apache License 2.0
1.14k stars 482 forks source link

[Feature]: log json folding #1415

Closed neopaf closed 1 year ago

neopaf commented 1 year ago

Requirement

As a user of Jaeger UI I want ability to fold long json blocks in span log entries so that simplify search of particular value.

Problem

Current JSON view only highlights keys, giving long hard-to find stuff view, example: Снимок экрана 2023-05-12 в 13 26 44

Currently we use long log messages of hundreds of lines, very hard to quickly navigate to important parts.

Proposal

Add folding interactions to JSON view, like in many JSON editors: Снимок экрана 2023-05-12 в 13 30 29

Possible options:

See more possible ideas here: https://www.jetbrains.com/help/rider/Code_Folding.html

But the basic: just ability to fold not-interesting region -- we absolutely need it.

Open questions

No response

yurishkuro commented 1 year ago

What if instead we provide an ability to open this JSON in a separate tab? There are tons of browser extensions for displaying JSON, with folding capabilities, etc., which we wouldn't need to support in Jaeger UI.

BenzeneAlcohol commented 1 year ago

Hey @yurishkuro , I would like to work on this. What method do you suggest, display JSON in a seperate tab or find out a way to do the minimisation within the UI?

GLVSKiriti commented 1 year ago

Hey @yurishkuro , Is this type of json view is still there now??, I tested it in hotrod app but I cant find this type of json view in span log entries in jaeger ui

yurishkuro commented 1 year ago

Hotrod doesn't log json content. We could change it if there is a reasonable bit of data, eg driver's x,y location could be logged as json to demo this UI feature

neopaf commented 1 year ago

Separate tab would help.

But, if that is possible, embedded UI would be ideal.

One of key wishes is "collapse to 1st level", maybe that should even be a default, or maybe "collapse on open if document is longer than 100 lines"