jaegertracing / jaeger-ui

Web UI for Jaeger
http://jaegertracing.io/
Apache License 2.0
1.11k stars 475 forks source link

[chore]: Fix eslint warnings #1608

Open punithnayak opened 1 year ago

punithnayak commented 1 year ago

What happened?

There some lint warnings shown

Steps to reproduce

  1. Go to the root dir of jaeger-UI
  2. run yarn lint

Expected behavior

There should be no eslint warnings

Relevant log output

`[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.test.js
[eslint       ]   178:23  warning  Unexpected unnamed function  func-names
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.tsx
[eslint       ]   117:18  warning  'createBlob' was used before it was defined  @typescript-eslint/no-use-before-define
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceStatistics/index.tsx
[eslint       ]   284:13  warning  Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element  jsx-a11y/no-static-element-interactions
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/selectors/span.js
[eslint       ]   15:1  warning  Prefer default export on a file with single export  import/prefer-default-export
[eslint       ] 
[eslint       ] ✖ 4 problems (0 errors, 4 warnings)
[eslint       ]

Screenshot

image

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

punithnayak commented 1 year ago

I am also planning to add lint check during ci/cd to prevent further lint warnings/errors in the code

yurishkuro commented 1 year ago

Some of the warnings are due to outdated APIs.

shuence commented 1 year ago

@yurishkuro Anyone Working on this? if not can you assign this to me?

yurishkuro commented 1 year ago

you can see linked issues/PRs for parts that are being work on. We do not assign issues.