Open anshgoyalevil opened 11 months ago
rrd
v6 has plenty of breaking changes compare to v4 that currently in use, I think we have to migrate it gradually.
Yes, we would have to upgrade it sequentially version by version, keeping the project intact
@anshgoyalevil do we have to migrate it to v5 before v6?
Yes. First v5, then 5.1, and then v6. (There can be more versions between 5.1 and 6, to which we would have to upgrade first).
Though it is a part of my LFX Mentorship, if you want to help out, you may DM me on Slack, and we can collaborate on another dependency upgrade, so that we both don't have to create the same type of PRs simultaneously.
This is a Tracker Issue for all react-router-dom related upgrades.
Route
defined insideindex.jsx
to use v6 API.elements
attribute. Example commit here.<Outlet />
instead ofprops.children
to render nested routes inside<Page />
. Example commit here.Useful resources:
<Outlet />
and<Switch>
components: https://github.com/jaegertracing/jaeger-ui/commit/ff22e64b9f991efe3dc69e7a8ae8dc0ee6436c91 (This commit was created as a part of the migration but is just a part of the story since it doesn't fixes the nested routing APIs and also doesn't use v6 Link component)