jaegertracing / jaeger-ui

Web UI for Jaeger
http://jaegertracing.io/
Apache License 2.0
1.15k stars 484 forks source link

Upgrade yarn to v3.8.5 #2459

Closed andreasgerstmayr closed 1 month ago

andreasgerstmayr commented 1 month ago

Which problem is this PR solving?

Description of the changes

The lint step is broken at the moment, because TypeScript incorrectly resolves the typings for react-router v5 with the types from react-router v6 (installed as a dependency of react-router-dom-v5-compat) instead of @types/react-router-dom. I'm not sure why this works correctly with yarn v1 though. See https://github.com/remix-run/react-router/discussions/9892

How was this change tested?

Checklist

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.61%. Comparing base (3c88048) to head (2344b6b). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2459 +/- ## ======================================= Coverage 96.61% 96.61% ======================================= Files 254 254 Lines 7679 7679 Branches 1931 1995 +64 ======================================= Hits 7419 7419 Misses 260 260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andreasgerstmayr commented 1 month ago

Hm, somehow the s390x build is stuck because of the upgrade to yarn v3. I'll see with IBM if we can get this resolved.

yurishkuro commented 1 month ago

We went with npm instead #2462