Closed andreasgerstmayr closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.61%. Comparing base (
241c2f8
) to head (37f91ae
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Which problem is this PR solving?
Fix babel dependencies in plexus repo
Description of the changes
PR #2485 produced an invalid dependency configuration: The
package.json
file specifies version7.26.0
: https://github.com/jaegertracing/jaeger-ui/blob/ef0bb277e0854be44792961f3218ef16fe783285/packages/plexus/package.json#L18 however, the locked version is7.25.2
: https://github.com/jaegertracing/jaeger-ui/blob/ef0bb277e0854be44792961f3218ef16fe783285/package-lock.json#L21849-L21850Same for the
@babel/preset-env
dependency.The error is visible with:
To prevent this error in the future, I added a check for this situation to the GitHub action.
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test