jaegertracing / jaeger-ui

Web UI for Jaeger
http://jaegertracing.io/
Apache License 2.0
1.15k stars 485 forks source link

Fix babel dependencies in plexus repo #2502

Closed andreasgerstmayr closed 1 week ago

andreasgerstmayr commented 1 week ago

Which problem is this PR solving?

Fix babel dependencies in plexus repo

Description of the changes

PR #2485 produced an invalid dependency configuration: The package.json file specifies version 7.26.0: https://github.com/jaegertracing/jaeger-ui/blob/ef0bb277e0854be44792961f3218ef16fe783285/packages/plexus/package.json#L18 however, the locked version is 7.25.2: https://github.com/jaegertracing/jaeger-ui/blob/ef0bb277e0854be44792961f3218ef16fe783285/package-lock.json#L21849-L21850

Same for the @babel/preset-env dependency.

The error is visible with:

$ npm ls --all
...
npm error code ELSPROBLEMS
npm error invalid: @babel/core@7.25.2 /home/agerstmayr/redhat/dev/jaeger-ui/packages/plexus/node_modules/@babel/core
npm error invalid: @babel/preset-env@7.25.4 /home/agerstmayr/redhat/dev/jaeger-ui/packages/plexus/node_modules/@babel/preset-env

To prevent this error in the future, I added a check for this situation to the GitHub action.

How was this change tested?

Checklist

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.61%. Comparing base (241c2f8) to head (37f91ae). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2502 +/- ## ======================================= Coverage 96.61% 96.61% ======================================= Files 254 254 Lines 7679 7679 Branches 1995 1995 ======================================= Hits 7419 7419 Misses 260 260 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.