Open pavolloffay opened 4 years ago
nit: please use pastebin for long json
I am surprised Process tags are even considered in the comparison. I would've though it should only be service/operationName.
@yurishkuro, @pavolloffay The comparison doesn't consider process tags. The reason the two reviews.bookinfo
nodes are not grouped is because one is a leaf while the other is not.
The span's traits drive the comparison are:
The code that generates this "group-ID":
While it's not really relevant to this ticket, another factor that affects the comparisons is that some spans within a trace are ignored when spans are assigned to groups. TLDR: client spans are ignored (generally).
When a service runs on different machines it produces different process objects. This causes that compare screen identifies the same service/operation_name as different. See the red node on the screenshot. Below the red node is the same node but it runs on a different machine so it is recognized as a different process.
If the ip/hostname is taken into account the compare feature might display misleading results in k8s environment when multiple replicas are being used.
https://pastebin.com/D2v9VYc8 https://pastebin.com/cFRXNrKq