search

jaegertracing / jaeger-ui

Web UI for Jaeger
http://jaegertracing.io/
Apache License 2.0
1.11k stars 475 forks source link

[Bug]: span tags of type int64 may lose precision #982

Open SealinGp opened 2 years ago

SealinGp commented 2 years ago

Corresponding issue in the backend: https://github.com/jaegertracing/jaeger/issues/3958

What happened?

i guess the package 'isomorphic-fetch' may loss of precision(int64) while proxy to load data from jaeger jaeger-ui: v1.14.0 jaeger: v1.24.0

Steps to reproduce

  1. start jaeger
  2. change packages/jaeger-ui/src/api/jaeger.js:42 && start jaeger-ui image 4.access /trace/4c5d7a066c367635704f06207dd56b45 page image image 5.aceess api directly image

6.we can find out the value of "liveroom_sid" changed 780177723283783680 -> 780177723283783700

Expected behavior

jaeger : response int64 value "780177723283783680" jaeger-ui: receive int64 value "780177723283783680" (but it shows "780177723283783700" )

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

v1.24.0

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

SealinGp commented 2 years ago

sorry, my bad. this bug is because 780177723283783680 overflow js Number.MAX_VALUE to cause precision loss,and i change the code image

will fix this, but it will copy bigint as string because of https://github.com/GoogleChromeLabs/jsbi/issues/30 image

plz let me know it if there is better way to fix this situation