jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.61k stars 2.45k forks source link

Translate OTEL status.code tag to human readable string #2489

Open pavolloffay opened 4 years ago

pavolloffay commented 4 years ago

OTEL span has a top-level status field in span https://github.com/open-telemetry/opentelemetry-collector/blob/aeb604f4a3227415ba6e209363fcaf7d93817b70/internal/data/opentelemetry-proto-gen/trace/v1/trace.pb.go#L361.

This field is added as a tag status.code to Jaeger span with an int value https://github.com/open-telemetry/opentelemetry-collector/blob/ec327358d6340342ee345869685f2bb00e8e2b91/translator/trace/jaeger/traces_to_jaegerproto.go#L411

In the UI the value is shown as int that is not human readable. The UI should translate it to a text representation https://github.com/open-telemetry/opentelemetry-collector/blob/aeb604f4a3227415ba6e209363fcaf7d93817b70/internal/data/opentelemetry-proto-gen/trace/v1/trace.pb.go#L107

yurishkuro commented 4 years ago

I recommend adding an adjuster to the backend (similar to clock skew adjuster), instead of doing this in the UI.

pavolloffay commented 4 years ago

It works for me, moving the issue to the core.