search

jaegertracing / jaeger

CNCF Jaeger, a Distributed Tracing Platform
https://www.jaegertracing.io/
Apache License 2.0
20.15k stars 2.4k forks source link

Extract github.com/jaegertracing/jaeger/model as a separate module #3217

Open bogdandrutu opened 3 years ago

bogdandrutu commented 3 years ago

In opentelemetry-collector we need this dependency because we need to accept data in Jaeger proto and convert them to/from collector pdata model.

Would be amazing to reduce dependencies on our side and depend only on the jaeger/model module.

yurishkuro commented 3 years ago

@bogdandrutu aside from some convenience functions, /model is just auto-generated classes from proto. I don' think that warrants a cross-dependency, why not just re-generate them in the collector?

bogdandrutu commented 3 years ago

Because you have manually written classes for example TraceId.

yurishkuro commented 3 years ago

We do, but the otel-collector does not need the functionality in those classes. In fact, those classes tie the implementation to a particular version of proto & gogo and are not compatible with the latest proto.

bogdandrutu commented 2 years ago

we done our part, but we would still prefer to not have to depend on the entire repo just for the conversion part. Also we want to support thrift (and is in the same package).

Would be a huge help for us to have that module independent.

yurishkuro commented 2 years ago

@bogdandrutu could you please point to the code that depends on jaeger/model?