Open bogdandrutu opened 3 years ago
@bogdandrutu aside from some convenience functions, /model
is just auto-generated classes from proto. I don' think that warrants a cross-dependency, why not just re-generate them in the collector?
Because you have manually written classes for example TraceId
.
We do, but the otel-collector does not need the functionality in those classes. In fact, those classes tie the implementation to a particular version of proto & gogo and are not compatible with the latest proto.
we done our part, but we would still prefer to not have to depend on the entire repo just for the conversion part. Also we want to support thrift (and is in the same package).
Would be a huge help for us to have that module independent.
@bogdandrutu could you please point to the code that depends on jaeger/model?
In opentelemetry-collector we need this dependency because we need to accept data in Jaeger proto and convert them to/from collector pdata model.
Would be amazing to reduce dependencies on our side and depend only on the jaeger/model module.